Closed burnout87 closed 6 months ago
With https://github.com/oda-hub/dispatcher-app/pull/683/commits/70fbada53c5daf82fd468531b50eebc4b3011bff the download_products
and download_file
endpoints can be reached also with dispatch-data/download_products
and dispatch-data/download_file
respectively.
The need for this came from some issues I am encountering when doing some local testing. In particular, when running locally, the url for the download would contain dispatch-data
, and those endpoints would not be originally reachable (which would be when in production though).
I am thinking that probably this change is not going to have an impact in the current platform since the original endpoint will be still reachable, yet I am wondering if this is too "hacky".
What do you think @volodymyrss @dsavchenko ?
With 70fbada the
download_products
anddownload_file
endpoints can be reached also withdispatch-data/download_products
anddispatch-data/download_file
respectively.The need for this came from some issues I am encountering when doing some local testing. In particular, when running locally, the url for the download would contain
dispatch-data
, and those endpoints would not be originally reachable (which would be when in production though).I am thinking that probably this change is not going to have an impact in the current platform since the original endpoint will be still reachable, yet I am wondering if this is too "hacky".
What do you think @volodymyrss @dsavchenko ?
after a discussion with @dsavchenko , we agreed on:
update_par_dic_with_uploaded_files
function, and to adapt accordingly the nb2workflow, this will ensure a more consistent check for mmoda_url on the backend sidenow the nb2wporkflow and dispatcher-app use the same version of the library validators
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #683 +/- ## ========================================== + Coverage 62.21% 62.32% +0.10% ========================================== Files 50 50 Lines 8925 8951 +26 ========================================== + Hits 5553 5579 +26 Misses 3372 3372 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.