oda-hub / dispatcher-app

Other
2 stars 2 forks source link

validators version issue? #692

Closed volodymyrss closed 5 months ago

volodymyrss commented 5 months ago

https://github.com/oda-hub/dispatcher-app/blob/e4b778401cd190512bfd18c69ec4ec27863d2a51/requirements.txt#L39

this breaks in here

https://github.com/oda-hub/oda_api/actions/runs/9135072621/job/26304556424

Why could it be?

burnout87 commented 5 months ago

That happens because there is an attempt to installs the library validators at the latest version, with python 3.7, which is not compatible .

We never saw on the dispatcher because we run out github workflows using python 3.8 and up, never 3.7.

Can we remove the support to that python version ?

volodymyrss commented 5 months ago

there is now a problem with bokeh - numpy compatibility. Can we safely upgrade bokeh or should we freeze numpy?

burnout87 commented 5 months ago

I quickly tried to install the latest versions of bokeh and numpy and I don't see that error, but of course it is not a guarantee

volodymyrss commented 5 months ago

I quickly tried to install the latest versions of bokeh and numpy and I don't see that error, but of course it is not a guarantee

If it works for the dispatcher visualization, if you tried that on your dev instance, lets upgrade. Could you check if it works on a dev instance?

burnout87 commented 5 months ago

no, I spoke a bit too early, and it seems there would be more problems upgrading bokeh https://github.com/oda-hub/dispatcher-app/actions/runs/9584813165/job/26429259309?pr=693

volodymyrss commented 5 months ago

no, I spoke a bit too early, and it seems there would be more problems upgrading bokeh https://github.com/oda-hub/dispatcher-app/actions/runs/9584813165/job/26429259309?pr=693

need to pick one that works I guess

burnout87 commented 5 months ago

it seems like that by freezing the numpy version the issue is solved:

numpy==1.24.4
burnout87 commented 5 months ago

ok, it seems that https://github.com/oda-hub/dispatcher-app/pull/693 fixed it I guess we can close this?