search

oda-hub / dispatcher-app

Other
2 stars 2 forks source link

Plot tools in oda_api #706

Open dsavchenko opened 1 month ago

dsavchenko commented 1 month ago

Following https://github.com/oda-hub/oda_api/pull/279 Removing code duplication in plot_tools

dsavchenko commented 1 month ago

@volodymyrss there are unige-related connection errors in tests

volodymyrss commented 1 month ago

Some UNIGE servers are down for an upgrade today. The tests fetch test products from there. Could you maybe add a label and conditionally skip them to see that all else is good?..

dsavchenko commented 1 month ago

Could you maybe add a label and conditionally skip them to see that all else is good?..

Well, this PR is almost empty now, and it is currently to check compatibility of dependencies. So we can just wait for these servers

volodymyrss commented 1 month ago

Could you maybe add a label and conditionally skip them to see that all else is good?..

Well, this PR is almost empty now, and it is currently to check compatibility of dependencies. So we can just wait for these servers

Normally the maintainance should be over, so perhaps there was a problem. I asked.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.33%. Comparing base (6e98f24) to head (2778e6e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #706 +/- ## ======================================= Coverage 62.33% 62.33% ======================================= Files 50 50 Lines 8982 8982 ======================================= Hits 5599 5599 Misses 3383 3383 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.