search

oda-hub / dispatcher-plugin-integral

Other
1 stars 1 forks source link

Patch to fix a bug (Experimental) #107

Closed ferrigno closed 1 year ago

ferrigno commented 1 year ago

It should solve:

https://github.com/oda-hub/dispatcher-plugin-integral/issues/106#issuecomment-1351644581

needs to be tested, but I do not know how.

volodymyrss commented 1 year ago

let's see what #105 does.

We need to test, yes. We can adapt the request in https://github.com/oda-hub/dispatcher-plugin-integral/blob/master/tests/test_isgri_plugin.py#L284

volodymyrss commented 1 year ago

please see https://github.com/oda-hub/dispatcher-plugin-integral/issues/106#issuecomment-1351706685 and let me know!

volodymyrss commented 1 year ago

Thanks for checking!

But I think we do need to merge this now. Ultimately it could be a complemetary change, but I am concerned that skipping results when not clear is not ideal: it's better to try to transform and fail if there is an issue

ferrigno commented 1 year ago

This happens if the light curve has no entries. Difficult yo understand the reason, but it might be the source out of fov or GTI issues. Strange not to have it seen before.

Il Mer 14 Dic 2022, 18:04 Volodymyr @.***> ha scritto:

Thanks for checking!

But I think we do need to merge this now. Ultimately it could be a complemetary change, but I am concerned that skipping results when not clear is not ideal: it's better to try to transform and fail if there is an issue

— Reply to this email directly, view it on GitHub https://github.com/oda-hub/dispatcher-plugin-integral/pull/107#issuecomment-1351779287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATI746N5RUC2SGBOISMDXTWNH42DANCNFSM6AAAAAAS6UQTWY . You are receiving this because you authored the thread.Message ID: @.***>