OSA version modifiers

[pep8speaks]

Hello @volodymyrss! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file cdci_osa_plugin/osa_common_pars.py:

Line 91:38: E252 missing whitespace around parameter equals Line 91:39: E252 missing whitespace around parameter equals Line 92:37: E252 missing whitespace around parameter equals Line 92:38: E252 missing whitespace around parameter equals Line 92:43: W291 trailing whitespace Line 93:65: E252 missing whitespace around parameter equals Line 93:66: E252 missing whitespace around parameter equals Line 94:66: E252 missing whitespace around parameter equals Line 94:67: E252 missing whitespace around parameter equals Line 94:73: W291 trailing whitespace Line 97:80: E501 line too long (102 > 79 characters) Line 102:80: E501 line too long (85 > 79 characters) Line 105:80: E501 line too long (87 > 79 characters) Line 107:80: E501 line too long (83 > 79 characters) Line 118:1: W293 blank line contains whitespace Line 119:5: E303 too many blank lines (2) Line 124:5: E303 too many blank lines (2) Line 127:80: E501 line too long (86 > 79 characters) Line 130:80: E501 line too long (98 > 79 characters) Line 131:80: E501 line too long (106 > 79 characters) Line 131:107: W291 trailing whitespace Line 132:80: E501 line too long (150 > 79 characters) Line 132:151: W291 trailing whitespace Line 135:80: E501 line too long (116 > 79 characters) Line 137:80: E501 line too long (120 > 79 characters) Line 138:37: E127 continuation line over-indented for visual indent Line 141:80: E501 line too long (100 > 79 characters) Line 142:80: E501 line too long (86 > 79 characters) Line 163:49: W291 trailing whitespace Line 164:46: W291 trailing whitespace Line 165:80: E501 line too long (84 > 79 characters) Line 166:80: E501 line too long (85 > 79 characters) Line 167:1: W293 blank line contains whitespace Line 180:1: E302 expected 2 blank lines, found 1 Line 183:1: E302 expected 2 blank lines, found 1 Line 185:1: W293 blank line contains whitespace Line 199:80: E501 line too long (157 > 79 characters) Line 200:29: E127 continuation line over-indented for visual indent Line 203:80: E501 line too long (81 > 79 characters) Line 205:80: E501 line too long (183 > 79 characters) Line 207:63: W292 no newline at end of file

• In the file cdci_osa_plugin/osa_dataserve_dispatcher.py:

Line 716:80: E501 line too long (96 > 79 characters) Line 721:80: E501 line too long (151 > 79 characters) Line 722:67: E127 continuation line over-indented for visual indent Line 722:80: E501 line too long (110 > 79 characters) Line 722:111: W291 trailing whitespace

• In the file cdci_osa_plugin/osa_spectrum_query.py:

Line 59:29: E271 multiple spaces after keyword Line 370:80: E501 line too long (96 > 79 characters)

• In the file tests/test_authorization.py:

Line 270:80: E501 line too long (89 > 79 characters) Line 281:80: E501 line too long (81 > 79 characters) Line 282:80: E501 line too long (157 > 79 characters) Line 282:158: W291 trailing whitespace

• In the file tests/test_basic.py:

Line 88:80: E501 line too long (97 > 79 characters) Line 91:80: E501 line too long (119 > 79 characters) Line 92:80: E501 line too long (139 > 79 characters) Line 93:80: E501 line too long (115 > 79 characters) Line 100:80: E501 line too long (91 > 79 characters) Line 104:1: W293 blank line contains whitespace Line 105:5: E303 too many blank lines (2) Line 108:80: E501 line too long (89 > 79 characters) Line 113:5: E303 too many blank lines (2) Line 116:80: E501 line too long (82 > 79 characters)

Comment last updated at 2021-09-27 14:47:17 UTC

[burnout87]

FYI I was already adjusting some default values, including the osa_version but this addresses the problem better.

[volodymyrss]

FYI I was already adjusting some default values, including the osa_version but this addresses the problem better.

Ok, thanks. We still need to set osa_version default somewhere. This addresses not so much the defaults, but special treatment for osa_version validation. Due to it being multi-component string.

[codecov-commenter]

Codecov Report

Merging #58 (50d367d) into master (ebf77e1) will increase coverage by 0.90%. The diff coverage is 42.25%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   24.20%   25.10%   +0.90%     
==========================================
  Files          11       11              
  Lines        1326     1374      +48     
==========================================
+ Hits          321      345      +24     
- Misses       1005     1029      +24     

Impacted Files	Coverage Δ
cdci_osa_plugin/osa_dataserve_dispatcher.py	13.83% <0.00%> (+0.07%)	:arrow_up:
cdci_osa_plugin/osa_isgri.py	38.46% <0.00%> (-1.02%)	:arrow_down:
cdci_osa_plugin/osa_jemx.py	35.00% <0.00%> (-0.90%)	:arrow_down:
cdci_osa_plugin/osa_common_pars.py	45.83% <48.21%> (+5.83%)	:arrow_up:
cdci_osa_plugin/osa_spectrum_query.py	20.24% <75.00%> (-0.56%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebf77e1...50d367d. Read the comment docs.