oda-hub / dispatcher-plugin-integral

Other
1 stars 1 forks source link

osa11-beta in other places #70

Closed volodymyrss closed 2 years ago

pep8speaks commented 2 years ago

Hello @volodymyrss! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 246:44: W291 trailing whitespace Line 247:80: E501 line too long (87 > 79 characters) Line 248:80: E501 line too long (127 > 79 characters)

Line 504:80: E501 line too long (114 > 79 characters) Line 505:80: E501 line too long (134 > 79 characters) Line 505:135: W291 trailing whitespace

Line 387:13: E265 block comment should start with '# ' Line 388:49: E231 missing whitespace after ',' Line 388:80: E501 line too long (114 > 79 characters) Line 388:86: E231 missing whitespace after ',' Line 388:115: W291 trailing whitespace Line 389:80: E501 line too long (117 > 79 characters)

codecov-commenter commented 2 years ago

Codecov Report

Merging #70 (847e9fa) into master (c50746c) will decrease coverage by 0.12%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   25.10%   24.98%   -0.13%     
==========================================
  Files          11       11              
  Lines        1374     1381       +7     
==========================================
  Hits          345      345              
- Misses       1029     1036       +7     
Impacted Files Coverage Δ
cdci_osa_plugin/osa_image_query.py 32.91% <0.00%> (-0.42%) :arrow_down:
cdci_osa_plugin/osa_lightcurve_query.py 16.55% <0.00%> (-0.12%) :arrow_down:
cdci_osa_plugin/osa_spectrum_query.py 20.55% <0.00%> (-0.25%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c50746c...847e9fa. Read the comment docs.

volodymyrss commented 2 years ago

hm, I meant to merge another (non-hotfix) branch, with identical content. Oh well.