search

oda-hub / dispatcher-plugin-integral

Other
1 stars 1 forks source link

Insert warning if in JEM-X light curve a user asks for <0.1s time bins #86

Closed ferrigno closed 2 years ago

ferrigno commented 3 years ago

j_ima_iros minimum time bin is 0.1 s with default to 4 s the same is reflected in jemx_science_analysis

I have made a request from the API with 0.02 s bin job_id: 2bbfe99e and one from the web interface with 0.02 s time bin job_id: e2c6aace

They both returned a light curve with 4 s time bin.

It is a good safety feature, but one should warn the user that the query parameters have been adapted to reflect limits.

[I do not know if this is even possible in automatic fashion, but we discussed something on weird inputs for ISGRI energy range]

volodymyrss commented 3 years ago

it is, in principle, an unintuitive issue of feature of jemx_science_analysis, which silently chooses the default in this case:

https://gitlab.astro.unige.ch/integral/components/j_scripts/-/blob/master/jemx_scw_analysis/jemx_scw_analysis.C#L596

it would take more time to do it on dispatcher, there is an issue group for that kind of stuff https://github.com/oda-hub/dispatcher-app/issues/127

I will associate it there. But for now I made a warning coming from the backend:

image

volodymyrss commented 2 years ago

this is done, presumably.