oda-hub / frontend-tab-generator

0 stars 0 forks source link

"DEC_rename" etc in the parameter list? #20

Closed volodymyrss closed 8 months ago

volodymyrss commented 8 months ago

image

built from https://gitlab.renkulab.io/astronomy/mmoda/ibis-isgri-spectrum/-/blob/main/isgri-full-image-sextractor.ipynb?ref_type=heads

dsavchenko commented 8 months ago

Probably it's not documented, but this is intentional. If the parameter have the name of the "source query" parameters (the ones from the top panel) but is not explicitly annotated, it gets renamed and is treated as an instrument parameter

volodymyrss commented 8 months ago

Ok, makes sense, but they are annotated, see repo link. Maybe not the right term?

dsavchenko commented 8 months ago

You are right, by explicitly I meant with special terms for these inputs: oda:PointOfInterestRA, oda:PointOfInterestDec These terms are listed here

Note that these parameters should be consistently annotated in all notebooks in the repo. Otherwise, the behaviour is not well-defined.