search

oda-hub / frontend-tab-generator

0 stars 0 forks source link

could we put somewhere at the end the instrument version? #35

Closed volodymyrss closed 2 months ago

dsavchenko commented 2 months ago

It's possible. Where do you propose to put it? I'm not sure if it will look nice in the instrument tab ("versions" now are just commit ids). @andriineronov what do you think? @motame @burnout87 maybe you may propose (not every place in the frontend is equally easily accessible for tab generator, I suppose)

burnout87 commented 2 months ago

What about right below the name?

image

It can easily be added from the .install file and then in the main template file of the module

andriineronov commented 2 months ago

I think this can be useful... May be on the instrument-specific parameter panel, e.g. at the bottom?

volodymyrss commented 2 months ago

I think this can be useful... May be on the instrument-specific parameter panel, e.g. at the bottom?

That's what I thought too. A version as in time, commit/tag (git describe --always --tags) linking to the original repo at this revision.

burnout87 commented 2 months ago

something like that ?

image

image

volodymyrss commented 2 months ago

I'd say yes, like that, but with the version of the instrument.

What you put now is some other version of the frontend/dispatcher, and by the way not such a bad idea to put them somewhere too. Somewhere at the bottom?

burnout87 commented 2 months ago

I'd say yes, like that, but with the version of the instrument.

Which version are you referring to ?

What you put now is some other version of the frontend/dispatcher, and by the way not such a bad idea to put them somewhere too. Somewhere at the bottom?

what I have put now is the output of the command git describe --tags, from the repo of the integral plugin (since I am testing for the ISGRI instrument).

volodymyrss commented 2 months ago

I'd say yes, like that, but with the version of the instrument. Which version are you referring to ?

Version of the instrument repository. Maybe it's better that @dsavchenko just adds it so you can see.

What you put now is some other version of the frontend/dispatcher, and by the way not such a bad idea to put them somewhere too. Somewhere at the bottom? what I have put now is the output of the command git describe --tags, from the repo of the integral plugin (since I am testing for the ISGRI instrument).

For ISGRI instrument this would be the way. But it's not so critical to put version for this one since it's not updating often.

burnout87 commented 2 months ago

For ISGRI instrument this would be the way. But it's not so critical to put version for this one since it's not updating often.

As for the position, is it ok?

volodymyrss commented 2 months ago

For ISGRI instrument this would be the way. But it's not so critical to put version for this one since it's not updating often.

As for the position, is it ok?

I suppose so.