search

oda-hub / frontend-tab-generator

0 stars 0 forks source link

frontend crashes with new crbeam #53

Closed volodymyrss closed 3 weeks ago

volodymyrss commented 1 month ago 
[Sign in ](https://localhost:8443/mmoda/user/login)Sign up
[×](https://localhost:8443/#)
Error message
ParseError: syntax error, unexpected '",' (T_CONSTANT_ENCAPSED_STRING), expecting ')' in module_load_include() (line 1037 of /var/www/mmoda/sites/all/modules/mmoda/instruments/mmoda_crbeam/mmoda_crbeam.inc).
burnout87 commented 1 month ago

I guess you see that error message when trying to load the frontend, correct?

I managed to build it properly locally, using the branch from #49 , as well as the master:

image

volodymyrss commented 1 month ago

No, as the title says, the frontend crashes. I manually removed crbeam module from the frontend which left the error message.

You sure use the latest crbeam version, from yesterday? You can see it broke in CI too.

volodymyrss commented 1 month ago

@okolo , I will try to revert your last change of yesterday https://gitlab.renkulab.io/astronomy/mmoda/crbeam/-/commit/9ecc62447d59896e96984e84da2403a8d2cebd21

edit: although it does not look to be relevant

burnout87 commented 1 month ago

You sure use the latest crbeam version, from yesterday? You can see it broke in CI too.

This one right: a850e30fc46d95e5b896473020c6b257385909b7

I tried it and I could build it (using the master version of the tab-generator)

volodymyrss commented 1 month ago

hm, could you please attach here crbeam.inc you are getting? For me it causes this issue.

volodymyrss commented 1 month ago

You can upload the file if you gzip it. Here crbeam.inc.gz

burnout87 commented 1 month ago

mmoda_crbeam.inc.gz

burnout87 commented 1 month ago

You can upload the file if you gzip it. Here crbeam.inc.gz

Ok thanks. I see the error that causes the crash

burnout87 commented 1 month ago

And I can confirm that with the latest PR #49 , it will be fixed

volodymyrss commented 1 month ago

Could you check that the problem is present with the latest integrated image? odahub/oda-bot:edff3c9-240916025940-master built in https://github.com/oda-hub/oda-bot/actions/runs/10876814663/job/30177268543 .

If yes we should merge the fix ASAP.

burnout87 commented 1 month ago

Yes, I see from the log that the bot cloned 2ee02755ff8b1451dfed406292f69e014b6c5458 , which has the bug

volodymyrss commented 1 month ago

We should merge today. Either the whole Euclid thing or just the bug fix.

volodymyrss commented 1 month ago

The deployed version still failed. Maybe some rushed deployement. Could you cross check that the latest bot image is producing good frontend tab?

burnout87 commented 1 month ago

the latest bot image is checking 3f5bd3f4d1dfe0eba357cb548e090b4e9ffb5012 commit of the generator, so correctly

locally, I could also generate it properly

but at the moment, on the frontend I dont see an error about the *.inc file, perhaps it's something related to the installation of the module itself?

Can you share the new mmoda_crbeam.inc file ? thanks

volodymyrss commented 1 month ago

I can not easily do it right now. Could you run the generator in this image and see what you get?

It does not show error because I deleted the instrument directory again.

volodymyrss commented 1 month ago

still getting this

ParseError: syntax error, unexpected '",' (T_CONSTANT_ENCAPSED_STRING), expecting ')' in module_load_include() (line 1037 of /var/www/mmoda/sites/all/modules/mmoda/instruments/mmoda_crbeam/mmoda_crbeam.inc).
volodymyrss commented 1 month ago

mmoda_crbeam.inc.gz

burnout87 commented 1 month ago

that's really weird, the error is exactly the same, despite having seen the bot checking out the latest commit of the generator

volodymyrss commented 1 month ago

could you check what's in the container? do docker run -it ... and look inside it for the code you changed for the bugfix.

burnout87 commented 1 month ago

I did some investigation and it is running the latest code of the generator