can we have a nice notebook view modal in case of the failure? I think we talked about it?

oda-hub / mmoda-frontend-module

GNU General Public License v2.0

0 stars 1 forks source link

can we have a nice notebook view modal in case of the failure? I think we talked about it? #244

Open volodymyrss opened 3 months ago

volodymyrss commented 3 months ago

burnout87 commented 3 months ago

Yes, and the button is indeed visible.

Now the question is why is it not enabled? Enabling takes place under the following conditions:

the instrument has to support the return progress (eg 'support_return_progress' => 'true' , https://github.com/oda-hub/frontend-tab-generator/commit/9c5a4e14223a68be1ecb62428054dcd192b5ceb1 ), was this change applied to the instrument you tested?
a status of progress or ready must have been returned, was it the case?
- if not the case, could it be that the notebook output was generated by the nb2service in the backend, but yet neither the status progress or ready were returned?

for which instrument/product was the request?

burnout87 commented 3 months ago

Yes, and the button is indeed visible.

Now the question is why is it not enabled? Enabling takes place under the following conditions:

the instrument has to support the return progress (eg 'support_return_progress' => 'true' , oda-hub/frontend-tab-generator@9c5a4e1 ), was this change applied to the instrument you tested?

a status of progress or ready must have been returned, was it the case?

I just checked for the instrument HESS (I think that is the one), and I could verify that a status of ready was actually returned, and what is missing is the adaptation of the attributes of the instrument

volodymyrss commented 3 months ago

I just checked for the instrument HESS (I think that is the one), and I could verify that a status of ready was actually returned, and what is missing is the adaptation of the attributes of the instrument

I don't remember, why is this custom setting needed? Can it be not always shown if available?

Also, here

There is a duplication, no?

burnout87 commented 2 months ago

I don't remember, why is this custom setting needed? Can it be not always shown if available?

The button is visible, just not enabled if the functionality is not supported by the instrument. I included that so that instruments that do not support return progress (eg integral instruments), never show the button enabled, even if they return progress or ready status.

The "inspect notebook" link would disappear with https://github.com/oda-hub/dispatcher-plugin-nb2workflow/pull/94