oda-hub / mmoda-frontend-module

GNU General Public License v2.0
0 stars 1 forks source link

stray modal opening when clicking on news item #249

Open volodymyrss opened 7 months ago

volodymyrss commented 7 months ago

previously, I ran some analysis. Now this happens when I just click on news item:

image

burnout87 commented 7 months ago

So:

volodymyrss commented 7 months ago

And yet it happens sometimes, @burnout87 . There must be some issues with state management and race conditions. It would help to think about where it can go wrong in this case.

This sort of issues are not easy to reproduce. I suggest you try to run different requests and click on different things in different order.

volodymyrss commented 7 months ago

related case I think

image

@burnout87 please to request different things and stop at different time to reproduce

burnout87 commented 7 months ago

I tried to run multiple times different types of analysis, played around, but I really didn't manage to reproduce the issue when opening a news item.

In the meantime, with these two PRs more bugs should be fixed:

https://github.com/oda-hub/dispatcher-app/pull/670 https://github.com/oda-hub/dispatcher-plugin-nb2workflow/pull/100 (adaptation to the changes introduced in the dispatcher)

burnout87 commented 7 months ago

previously, I ran some analysis. Now this happens when I just click on news item:

image

This is fixed with https://github.com/oda-hub/mmoda-frontend-module/commit/584beaa1f411cbf67c097a502fccd71fee24d0cf

burnout87 commented 7 months ago

related case I think

image

I reproduced it locally, and I confirm this is fixed with https://github.com/oda-hub/mmoda-frontend-module/commit/f3ce11eadc846c677e8c973359e7a32bad24eed8