oda-hub / mmoda-frontend-module

GNU General Public License v2.0
0 stars 1 forks source link

Problem resolving most GW #253

Open dsavchenko opened 4 months ago

dsavchenko commented 4 months ago

GW150914 is "unknown object" in frontend. I checked by directly requesting the resolver, it resolves it well. So the problem is probably on the frontend side. @motame @burnout87 could you help me to debug it?

Another related issue: when the object is unknown, the button "resolve" becomes inactive and will become active only if one fully clears the field and inputs again. Just editing doesn't work.

burnout87 commented 4 months ago

Found this in the mmoda log

Notice: Undefined index: use_resolver in resolve_object_name_callback() (line 426 of /var/www/mmoda/sites/all/modules/mmoda/mmoda.common.inc).

burnout87 commented 4 months ago

BTW it seems that it is unknown

https://resolver-prod.obsuks1.unige.ch/api/v1.1/byname/GW150914 http://cdsweb.u-strasbg.fr/cgi-bin/nph-sesame/-oxp/NSV?GW150914

Or am I missing something ?

dsavchenko commented 4 months ago

BTW it seems that it is unknown

This is the first ever GW event, it should be known ;)

I don't know why this query to Simbad returns nothing. It can be found like this https://simbad.cds.unistra.fr/simbad/sim-basic?Ident=GW150914 (not very useful, though, as there is no defined coordinate, and no timing info in Simbad) But this doesn't matter.

We have a plugin for GW which proxies the requests to gwosc.org I can't, unfortunately, check with internal address of resolver in unige. It works by directly querying the resolver of my staging https://resolver.odahub.fr/api/v1.1/byname/GW150914 , but doesn't work in frontend there

burnout87 commented 4 months ago

I can confirm that the outputs of

https://resolver-prod.obsuks1.unige.ch/api/v1.1/byname/GW150914 and https://resolver.odahub.fr/api/v1.1/byname/GW150914

are identical. Or, again, I am missing something

dsavchenko commented 4 months ago

So it's resolved, actually. For most of GW, coordinates are not defined, what matters is time. I was sure it used to work before in the frontend, only setting time fields, but now it doesn't (except for GW170817 which is special as it has an electromagnetic counterpart, thus fixed coordinates)

burnout87 commented 3 months ago

can this be closed ? @dsavchenko

dsavchenko commented 3 months ago

can this be closed ? @dsavchenko

The intended behaviour for most GW (when coordinates are undefined) is to only set T1, T2, leaving coordinates unchanged (probably, some message of what actually are set would be useful).

dsavchenko commented 3 months ago

BTW, @volodymyrss I tried with GRBs to see how it works, and it seems that resolver doesn't return timing information, which looks strange to me. Does it have to be like this?

volodymyrss commented 3 months ago

There is not really a universal source of GRB time information. We inserted Polar GRB table there.

I had also parser based on https://github.com/oda-hub/literature-to-facts . We can re-enable it somehow https://github.com/oda-hub/oda-resolver/issues/17 .