search

oda-hub / mmoda-frontend-module

GNU General Public License v2.0
0 stars 1 forks source link

Once you edit a source only that one is used as inline catalog #37

Closed ferrigno closed 3 years ago

ferrigno commented 3 years ago

https://frontend.staging.odahub.io/cdci/astrooda/?src_name=4U+1700-377&RA=270.80&DEC=-29.80&T1=2021-05-01&T2=2021-05-05&T_format=isot&instrument=jemx&osa_version=OSA11.0&radius=4&use_scws=no&max_pointings=50&integral_data_rights=all-private&jemx_num=1&E1_keV=3&E2_keV=20&query_type=Real&detection_threshold=5&product_type=jemx_image&query_status=new

I look at the catalog, I edited a source to set flag=1 catalog-jemx edit-source

bu the inline catalog contains only that source afterwards !! image

ferrigno commented 3 years ago

Thsi cannot be a "KNOWN ISSUE" as it blocks a correct analysis. It needs to be solved.

burnout87 commented 3 years ago

I am looking into it, and discuss also with @motame

ferrigno commented 3 years ago

I realized that this happens only if you keep the source selected after you edit it !! If you unselect the source, the full catalog is used. I think this is unwanted, but not blocking.

burnout87 commented 3 years ago

Still, I think that once the edit is complete, thr full list should be visualized, unless I misunderstood the workflow

ferrigno commented 3 years ago

The list is visualized, but the source remains selected. If you click on "use catalog" with one source selected, only that one is used. It will cause several errors by the users, but it cannot be a stopper for release.

burnout87 commented 3 years ago

This was discussed, and decided thew current behavior is now ok.

If confirmed, we can close it.

volodymyrss commented 3 years ago

I've been using it for some time, seems ok!