oda-hub / mmoda-frontend-module

GNU General Public License v2.0
0 stars 1 forks source link

make_request with url does not pass catalog to jemx. #39

Closed volodymyrss closed 3 years ago

volodymyrss commented 3 years ago

make_request with url does not pass catalog to jemx. it always passes to ISGRI - first active tab. This means that request which is being sent is not what user expects.

volodymyrss commented 3 years ago
https://frontend.staging.odahub.io/cdci/astrooda/?DEC=-41.593417&E1_keV=3&E2_keV=35&RA=257.815417&T1=2003-03-15T23%3A27%3A40.0&T2=2033-03-16T00%3A03%3A15.0&T_format=isot&catalog_selected_objects=1%2C2%2C3%2C4%2C5&detection_threshold=5&instrument=jemx&integral_data_rights=all-private&jemx_num=1&max_pointings=5&osa_version=OSA10.2&product_type=jemx_spectrum&query_status=ready&query_type=Real&radius=12&selected_catalog=%7B%22cat_column_descr%22%3A%5B%5B%22meta_ID%22%2C%22%3Ci8%22%5D%2C%5B%22src_names%22%2C%22%3CU13%22%5D%2C%5B%22significance%22%2C%22%3Ef4%22%5D%2C%5B%22ra%22%2C%22%3Ef4%22%5D%2C%5B%22dec%22%2C%22%3Ef4%22%5D%2C%5B%22FLAG%22%2C%22%3Ci8%22%5D%2C%5B%22ERR_RAD%22%2C%22%3Cf8%22%5D%5D%2C%22cat_column_list%22%3A%5B%5B1%2C2%2C3%2C4%2C5%5D%2C%5B%224U+1708-40%22%2C%22H+1702-429%22%2C%22H+MORENAME-440%22%2C%22NEWNAME%22%2C%22XTE+J1709-267%22%5D%2C%5B19.44633674621582%2C30.876388549804688%2C115.74901580810547%2C50.509769439697266%2C37.94548797607422%5D%2C%5B258.0929260253906%2C256.5699157714844%2C257.2275695800781%2C262.99847412109375%2C257.381591796875%5D%2C%5B-40.857749938964844%2C-43.043094635009766%2C-44.103294372558594%2C-33.839576721191406%2C-26.6580753326416%5D%2C%5B0%2C0%2C0%2C0%2C0%5D%2C%5B0.05000000074505806%2C0.05000000074505806%2C0.05000000074505806%2C0.05000000074505806%2C0.05000000074505806%5D%5D%2C%22cat_column_names%22%3A%5B%22meta_ID%22%2C%22src_names%22%2C%22significance%22%2C%22ra%22%2C%22dec%22%2C%22FLAG%22%2C%22ERR_RAD%22%5D%2C%22cat_coord_units%22%3A%22deg%22%2C%22cat_frame%22%3A%22fk5%22%2C%22cat_lat_name%22%3A%22dec%22%2C%22cat_lon_name%22%3A%22ra%22%7D&src_name=4U+1700-377&use_scws=no
ferrigno commented 3 years ago

Could you confirm if it is solved in the test instance?

volodymyrss commented 3 years ago

It's better if we mention fixing commit or PR tin the issue. For PR there is github mechanism even to link issue to PR.

So far, this is not fixed, I guess:

https://github.com/oda-hub/frontend-astrooda/commits/master

burnout87 commented 3 years ago

This hasn't been taken care of so far. And I can look into it

burnout87 commented 3 years ago

Solved with the last merge