search

oda-hub / nb2workflow

GNU General Public License v3.0
1 stars 4 forks source link

notebooks should have access to requesters oda token #158

Closed volodymyrss closed 3 months ago

dsavchenko commented 5 months ago

Just realised that nb2workflow already has access to the token. In dispatcher, the token is a parameter in SourceQuery. So it ends up in the request to backend. Then it needs to be added to the notebook run, probably as an environment variable. We may use some convention, but dedicated annotation would be preferable.

The only edge case is when the notebook declares parameter named "token". Probably needs some change in the plugin.

Also to check if token affects job hash in nb2workflow. If so, needs to be underscored.

dsavchenko commented 4 months ago

Reopening as https://github.com/oda-hub/nb2workflow/pull/168 is still not merged