search

oda-hub / oda-bot

0 stars 0 forks source link

remove reload-plugin #50

Closed dsavchenko closed 5 months ago

dsavchenko commented 5 months ago

No more need to reload plugin after https://github.com/oda-hub/dispatcher-plugin-nb2workflow/pull/90 (it didn't work anyway due to multiple workers)

volodymyrss commented 5 months ago

why? how does it reload then?

dsavchenko commented 5 months ago

It doesn't need to be reloaded to be aware of the instruments in KG after introducing NB2WInstrumentFactoryIter.

So the reload endpoint is only used in case of changes in a static configuration file. Moreover, it can really only be used in tests, in the real production deployment there are multiple independent processes started by gunicorn and calling the reload endpoint affected only one of them, this was the reason for the disappearance of the newly added instruments.