Add basic types and image product

[codecov[bot]]

Codecov Report

Merging #168 (0ecb838) into master (6b5d953) will increase coverage by 1.75%. The diff coverage is 71.94%.

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   52.77%   54.52%   +1.75%     
==========================================
  Files          17       18       +1     
  Lines        2829     2960     +131     
==========================================
+ Hits         1493     1614     +121     
- Misses       1336     1346      +10     

Impacted Files	Coverage Δ
oda_api/json.py	57.89% <57.89%> (ø)
oda_api/api.py	62.26% <60.00%> (-0.07%)	:arrow_down:
oda_api/data_products.py	54.82% <64.10%> (+5.88%)	:arrow_up:
tests/test_data_products.py	44.35% <97.29%> (+7.75%)	:arrow_up:
tests/conftest.py	87.50% <0.00%> (+10.00%)	:arrow_up:
tests/test_plot_tools.py	100.00% <0.00%> (+42.85%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[dsavchenko]

@volodymyrss do we really need these new strict checks for type annotations (see failed action)?

[burnout87]

@volodymyrss do we really need these new strict checks for type annotations (see failed action)?

I had to address them too here: https://github.com/oda-hub/oda_api/pull/163#issuecomment-1311365481

[dsavchenko]

I had to address them too here: #163 (comment)

Great. I temporarily switched off this check in this PR and will profit from your work afterwards :)

[dsavchenko]

So, waiting for @burnout87 review?

[volodymyrss]

So, waiting for @burnout87 review?

If you want, @burnout87 , else let's go ahead. Say, in 2hr unless there are comments.

[volodymyrss]

It will need help though, as agreed in the example. Could you maybe just reference it here for the record?

[volodymyrss]

It will need help though, as agreed in the example. Could you maybe just reference it here for the record?

Is this the example, @dsavchenko https://renkulab.io/gitlab/dsavchenko/mmoda-nb2workflow-example ?

[dsavchenko]

Is this the example, @dsavchenko https://renkulab.io/gitlab/dsavchenko/mmoda-nb2workflow-example ?

Yes, but need to merge plugin before

[dsavchenko]

BTW @volodymyrss do you bump the version of oda_api somehow automatically?

[volodymyrss]

BTW @volodymyrss do you bump the version of oda_api somehow automatically?

Sort of.