search

oda-hub / oda_api

API client to access some of the MMODA resources: INTEGRAL, POLAR, ANTARES, LIGO/Virgo, SDSS
Other
2 stars 2 forks source link

issue placing sources on image with ODA #173

Closed volodymyrss closed 1 year ago

volodymyrss commented 1 year ago

Seems like maybe cat sources are not placed where they are in the image with oda_api.plot_tools? It looks If it is indeed a problem, it can affect gallery.

image image

You can look in this file, maybe start it in renkulab, or maybe go from the query itself.

https://renkulab.io/gitlab/astronomy/mmoda/mmoda-request/-/blob/4c4a572c4d3202e3df3c97b004c89e87dab88b79/api_code_269c482f9da99daf.ipynb

We just deployed this feature token passing to renku (which allows to look on large results in renku), and @andriineronov had a case related to the workshop here, I submitted it from phone, and explored in renku - all works!

ferrigno commented 1 year ago

This should solve the issue https://github.com/oda-hub/oda_api/pull/139/files/93fabfa89215b98f88c2157562b3685118d90157..0297568b95556133a08cc8b7f508fee226572e82

Not sure how to merge, as I am using this branch that Gabriele is developing.

ferrigno commented 1 year ago

I created a PR only with this modification https://github.com/oda-hub/oda_api/pull/175 It looks like something fails, I let @dsavchenko or @burnout87 checking