oda-hub / oda_api

API client to access some of the MMODA resources: INTEGRAL, POLAR, ANTARES, LIGO/Virgo, SDSS
Other
2 stars 2 forks source link

equivalent units representations in test #197

Closed dsavchenko closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #197 (b9d243c) into master (14a0fad) will increase coverage by 0.17%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   53.87%   54.04%   +0.17%     
==========================================
  Files          20       20              
  Lines        3978     3978              
==========================================
+ Hits         2143     2150       +7     
+ Misses       1835     1828       -7     
Impacted Files Coverage Δ
tests/test_data_products.py 98.82% <100.00%> (ø)

... and 2 files with indirect coverage changes

dsavchenko commented 1 year ago

The problem with "Executing notebook" workflow is

ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2k-fips  26 Jan 2017.

So it seems that one needs to either restrict urllib3 version or use other version of integralsw/osa-python container. The second option looks preferable, but probably requires building of the new container image. @volodymyrss is it you who maintain them?

burnout87 commented 1 year ago

The problem with "Executing notebook" workflow is

ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2k-fips  26 Jan 2017.

So it seems that one needs to either restrict urllib3 version or use other version of integralsw/osa-python container. The second option looks preferable, but probably requires building of the new container image. @volodymyrss is it you who maintain them?

What is the status on this? Was the new image generated?

volodymyrss commented 1 year ago

The problem with "Executing notebook" workflow is

ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2k-fips  26 Jan 2017.

So it seems that one needs to either restrict urllib3 version or use other version of integralsw/osa-python container. The second option looks preferable, but probably requires building of the new container image. @volodymyrss is it you who maintain them?

What is the status on this? Was the new image generated?

Please restrict packages for now. And make an issue to upgrade with new image.

volodymyrss commented 1 year ago

The problem with "Executing notebook" workflow is

ImportError: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with OpenSSL 1.0.2k-fips  26 Jan 2017.

So it seems that one needs to either restrict urllib3 version or use other version of integralsw/osa-python container. The second option looks preferable, but probably requires building of the new container image. @volodymyrss is it you who maintain them?

What is the status on this? Was the new image generated?

Please restrict packages for now. And make an issue to upgrade with new image.

it would be best to only restrict for the tests (only one test?) since we do not want the while client-installable package to be unnecessarily restricted

dsavchenko commented 1 year ago

Executing Notebook action now formally passes. In fact, there is execution error inside

papermill.exceptions.PapermillExecutionError: 
---------------------------------------------------------------------------
Exception encountered at "In [2]":
---------------------------------------------------------------------------
StdinNotImplementedError                  Traceback (most recent call last)
<ipython-input-2-1f33e1fe0b77> in <module>
      1 import getpass
----> 2 token = getpass.getpass('Insert the token')

/pyenv/versions/3.8.2/lib/python3.8/site-packages/ipykernel/kernelbase.py in getpass(self, prompt, stream)
    822         """
    823         if not self._allow_stdin:
--> 824             raise StdinNotImplementedError(
    825                 "getpass was called, but this frontend does not support input requests."
    826             )

StdinNotImplementedError: getpass was called, but this frontend does not support input requests.

is it expected?