oda-hub / oda_api

API client to access some of the MMODA resources: INTEGRAL, POLAR, ANTARES, LIGO/Virgo, SDSS
Other
2 stars 2 forks source link

Keep names of all products + new BinaryProduct #200

Closed dsavchenko closed 1 year ago

burnout87 commented 1 year ago

Live test is failing in the same way as https://github.com/oda-hub/oda_api/pull/199#issuecomment-1604285566

codecov[bot] commented 1 year ago

Codecov Report

Merging #200 (36fd7ef) into master (14a0fad) will increase coverage by 0.46%. The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   53.87%   54.33%   +0.46%     
==========================================
  Files          20       20              
  Lines        3978     4036      +58     
==========================================
+ Hits         2143     2193      +50     
- Misses       1835     1843       +8     
Impacted Files Coverage Δ
oda_api/api.py 76.03% <33.33%> (-0.59%) :arrow_down:
oda_api/data_products.py 58.91% <78.84%> (+1.35%) :arrow_up:
oda_api/json.py 57.89% <100.00%> (ø)
tests/test_data_products.py 98.95% <100.00%> (+0.13%) :arrow_up:

... and 2 files with indirect coverage changes

volodymyrss commented 1 year ago

what's with Untitled.ipynb

dsavchenko commented 1 year ago

what's with Untitled.ipynb

It was added by mistake