search

oda-hub / oda_api

API client to access some of the MMODA resources: INTEGRAL, POLAR, ANTARES, LIGO/Virgo, SDSS
Other
2 stars 2 forks source link

217 add functionality to send callback messages #225

Closed okolo closed 10 months ago

okolo commented 1 year ago

Progress reporter API was added

codecov[bot] commented 1 year ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (f8ce41a) 57.18% compared to head (a13948d) 57.70%.

Files Patch % Lines
oda_api/api.py 85.71% 4 Missing :warning:
tests/test_progress_report.py 90.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #225 +/- ## ========================================== + Coverage 57.18% 57.70% +0.51% ========================================== Files 22 23 +1 Lines 4723 4781 +58 ========================================== + Hits 2701 2759 +58 Misses 2022 2022 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

burnout87 commented 1 year ago

Is it also possible to add a test?

volodymyrss commented 11 months ago

Please add docs too, @okolo . See where they appear for this PR .

volodymyrss commented 11 months ago

Should an instance of the ProgressReporter be a member of any DispatcherAPI object?

I think it would be more clean and transparent

Because it's a different way to access dispatcher, it may be a separate class.