Closed dsavchenko closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e15d2e2
) 58.06% compared to head (f2ac820
) 58.06%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
These are definitely allowed by standards. Hope we won't encounter a need to use a path with url-encoded / some more allowed symbols
Would it be possible to provide an example/test ?
I had created a somewhat obfuscated url to directly access the staging dispatcher. It contains digits in the path part. I can change it, of course, but I see no reason for path to not contain digits. Tilde and dot are probably overshoot, I agree.
I had created a somewhat obfuscated url to directly access the staging dispatcher. It contains digits in the path part. I can change it, of course, but I see no reason for path to not contain digits. Tilde and dot are probably overshoot, I agree.
Sure, add numbers.
The failed live-test looks completely unrelated. Is it some transient issue with isgri?
Seems I'm not authorized to merge here, so please do if you agree
The failed live-test looks completely unrelated. Is it some transient issue with isgri?
Probably. Strange. By the way, something very strange is going on with testing all UNIGE sites since 3 days, even very basic ones, according to https://status.odahub.io/ they are going up and down all the time, i.e. randomly refuse connections. But I did not actually see failing response personally. Might be some new network filter according to some origins.
Seems I'm not authorized to merge here, so please do if you agree
Ok
These are definitely allowed by standards. Hope we won't encounter a need to use a path with url-encoded / some more allowed symbols
Would it be possible to provide an example/test ?
I think this comment was addressed, but please protest if not, @burnout87 !
These are definitely allowed by standards. Hope we won't encounter a need to use a path with url-encoded / some more allowed symbols
Would it be possible to provide an example/test ?
I think this comment was addressed, but please protest if not, @burnout87 !
My bad, I forgot to request the change, in any case I guess we'll have examples in the future.
These are definitely allowed by standards. Hope we won't encounter a need to use a path with url-encoded / some more allowed symbols
Would it be possible to provide an example/test ?
I think this comment was addressed, but please protest if not, @burnout87 !
My bad, I forgot to request the change, in any case I guess we'll have examples in the future.
Examples are included in the tests, or did you mean something else?
Examples are included in the tests, or did you mean something else?
it's ok, I didnt see the tests after they were added
These are definitely allowed by standards. Hope we won't encounter a need to use a path with url-encoded / some more allowed symbols