oda-hub / oda_api

API client to access some of the MMODA resources: INTEGRAL, POLAR, ANTARES, LIGO/Virgo, SDSS
Other
2 stars 1 forks source link

allow digits and some characters in url path #237

Closed dsavchenko closed 8 months ago

dsavchenko commented 8 months ago

These are definitely allowed by standards. Hope we won't encounter a need to use a path with url-encoded / some more allowed symbols

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e15d2e2) 58.06% compared to head (f2ac820) 58.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #237 +/- ## ======================================= Coverage 58.06% 58.06% ======================================= Files 23 23 Lines 4829 4829 ======================================= Hits 2804 2804 Misses 2025 2025 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

burnout87 commented 8 months ago

These are definitely allowed by standards. Hope we won't encounter a need to use a path with url-encoded / some more allowed symbols

Would it be possible to provide an example/test ?

dsavchenko commented 8 months ago

I had created a somewhat obfuscated url to directly access the staging dispatcher. It contains digits in the path part. I can change it, of course, but I see no reason for path to not contain digits. Tilde and dot are probably overshoot, I agree.

volodymyrss commented 8 months ago

I had created a somewhat obfuscated url to directly access the staging dispatcher. It contains digits in the path part. I can change it, of course, but I see no reason for path to not contain digits. Tilde and dot are probably overshoot, I agree.

Sure, add numbers.

dsavchenko commented 8 months ago

The failed live-test looks completely unrelated. Is it some transient issue with isgri?

Seems I'm not authorized to merge here, so please do if you agree

volodymyrss commented 8 months ago

The failed live-test looks completely unrelated. Is it some transient issue with isgri?

Probably. Strange. By the way, something very strange is going on with testing all UNIGE sites since 3 days, even very basic ones, according to https://status.odahub.io/ they are going up and down all the time, i.e. randomly refuse connections. But I did not actually see failing response personally. Might be some new network filter according to some origins.

Seems I'm not authorized to merge here, so please do if you agree

Ok

volodymyrss commented 8 months ago

These are definitely allowed by standards. Hope we won't encounter a need to use a path with url-encoded / some more allowed symbols

Would it be possible to provide an example/test ?

I think this comment was addressed, but please protest if not, @burnout87 !

burnout87 commented 8 months ago

These are definitely allowed by standards. Hope we won't encounter a need to use a path with url-encoded / some more allowed symbols

Would it be possible to provide an example/test ?

I think this comment was addressed, but please protest if not, @burnout87 !

My bad, I forgot to request the change, in any case I guess we'll have examples in the future.

volodymyrss commented 8 months ago

These are definitely allowed by standards. Hope we won't encounter a need to use a path with url-encoded / some more allowed symbols

Would it be possible to provide an example/test ?

I think this comment was addressed, but please protest if not, @burnout87 !

My bad, I forgot to request the change, in any case I guess we'll have examples in the future.

Examples are included in the tests, or did you mean something else?

burnout87 commented 8 months ago

Examples are included in the tests, or did you mean something else?

it's ok, I didnt see the tests after they were added