oda-hub / oda_api

API client to access some of the MMODA resources: INTEGRAL, POLAR, ANTARES, LIGO/Virgo, SDSS
Other
2 stars 2 forks source link

get_requested_resources method was added to Ontology #244

Closed okolo closed 8 months ago

okolo commented 8 months ago

Note, that I have temporarily changed the url of the ontology file to https://raw.githubusercontent.com/oda-hub/ontology/storage_resource_annotations/ontology.ttl in python-package.yml . This is needed for unit tests. As soon as ontology pull request is done the change in python-package.yml should be reverted.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 97.82609% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 58.82%. Comparing base (c889b20) to head (a9aa0c1).

Files Patch % Lines
oda_api/ontology_helper.py 97.22% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #244 +/- ## ========================================== + Coverage 58.30% 58.82% +0.52% ========================================== Files 23 23 Lines 4849 4894 +45 ========================================== + Hits 2827 2879 +52 + Misses 2022 2015 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

okolo commented 8 months ago

The tests do not pass due to error in test_plot_tools_notebook, which has nothing to do with get_requested_resources

volodymyrss commented 8 months ago

The tests do not pass due to error in test_plot_tools_notebook, which has nothing to do with get_requested_resources

What is the error? If you notice it, could you make an issue? If it's complex to fix it quickly, please mark the tests skipped.

dsavchenko commented 8 months ago

What is the error? If you notice it, could you make an issue? If it's complex to fix it quickly, please mark the tests skipped.

This was some transient issue with the prod instance, I think. Fixed by rerunning. Could you merge, nb2workflow now depends on this change in master

dsavchenko commented 8 months ago

Could you merge

@volodymyrss