oda-hub / oda_api

API client to access some of the MMODA resources: INTEGRAL, POLAR, ANTARES, LIGO/Virgo, SDSS
Other
2 stars 2 forks source link

158 notebooks should have access to requesters oda token #248

Closed okolo closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 58.88%. Comparing base (8186112) to head (f5a9b65).

Files Patch % Lines
oda_api/api.py 81.25% 3 Missing :warning:
tests/test_plot_tools.py 80.00% 1 Missing :warning:
tests/test_progress_report.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #248 +/- ## ========================================== + Coverage 58.64% 58.88% +0.23% ========================================== Files 23 23 Lines 4897 4918 +21 ========================================== + Hits 2872 2896 +24 + Misses 2025 2022 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

volodymyrss commented 6 months ago

As mentioned, @okolo will look into the failed test (even if it's not because of the changes of this PR)

okolo commented 6 months ago

Currently test fails due to error while running Show_and_Save_Products.ipynb during request to 'https://www.astro.unige.ch/mmoda/dispatch-data' to search for thermonuclear bursts in the JEM-X light curve with error message "something went quite wrong, and we think it's not likely to recover on its own: [ RequestNotUnderstood: RequestNotUnderstood():[ InstrumentQueryBackEnd : jemx ] constructor failed: Found two non aliased identical job_id ]". The behavior is similar in master branch. @volodymyrss do you have any suggestions?

volodymyrss commented 6 months ago

Currently test fails due to error while running Show_and_Save_Products.ipynb during request to 'https://www.astro.unige.ch/mmoda/dispatch-data' to search for thermonuclear bursts in the JEM-X light curve with error message "something went quite wrong, and we think it's not likely to recover on its own: [ RequestNotUnderstood: RequestNotUnderstood():[ InstrumentQueryBackEnd : jemx ] constructor failed: Found two non aliased identical job_id ]". The behavior is similar in master branch. @volodymyrss do you have any suggestions?

What if you just download and run the notebook, does it fail in the same way?

okolo commented 6 months ago

Currently test fails due to error while running Show_and_Save_Products.ipynb during request to 'https://www.astro.unige.ch/mmoda/dispatch-data' to search for thermonuclear bursts in the JEM-X light curve with error message "something went quite wrong, and we think it's not likely to recover on its own: [ RequestNotUnderstood: RequestNotUnderstood():[ InstrumentQueryBackEnd : jemx ] constructor failed: Found two non aliased identical job_id ]". The behavior is similar in master branch. @volodymyrss do you have any suggestions?

What if you just download and run the notebook, does it fail in the same way?

I've tried to run the notebook in jupyter. The error persists. Here is the notebook output Show_and_Save_Products.html.zip

volodymyrss commented 6 months ago

Currently test fails due to error while running Show_and_Save_Products.ipynb during request to 'https://www.astro.unige.ch/mmoda/dispatch-data' to search for thermonuclear bursts in the JEM-X light curve with error message "something went quite wrong, and we think it's not likely to recover on its own: [ RequestNotUnderstood: RequestNotUnderstood():[ InstrumentQueryBackEnd : jemx ] constructor failed: Found two non aliased identical job_id ]". The behavior is similar in master branch. @volodymyrss do you have any suggestions?

What if you just download and run the notebook, does it fail in the same way?

I've tried to run the notebook in jupyter. The error persists. Here is the notebook output Show_and_Save_Products.html.zip

Looks like there was some strange behavior with this product on the live instance, must be related to a recent update. Anyway now it's passing.