search

oda-hub / oda_api

API client to access some of the MMODA resources: INTEGRAL, POLAR, ANTARES, LIGO/Virgo, SDSS
Other
2 stars 1 forks source link

ensure ogip lightcurve is produced by oda api #267

Open volodymyrss opened 1 month ago

volodymyrss commented 1 month ago

as reminded by https://github.com/esg-epfl-apc/tools-astro/issues/115#issuecomment-2222488660 and it's good to follow the standard.

@burnout87 I think you dealt with this?

burnout87 commented 1 month ago

I suppose you refer to https://github.com/oda-hub/oda_api/blob/7dcb229b34f166ac769477521a121f44d5ffb0fa/oda_api/plot_tools.py#L418 ?

@ferrigno and I worked on it (mainly) for the gallery

dsavchenko commented 1 month ago

I suppose you refer to

It's about https://github.com/oda-hub/oda_api/blob/7dcb229b34f166ac769477521a121f44d5ffb0fa/oda_api/data_products.py#L754

Of course, these parts should not be completely separated (as well as image, spectrum etc) This will require some refactoring

Even worse, we have some logic (mainly visualisation) in dispatcher plugin https://github.com/oda-hub/dispatcher-plugin-nb2workflow/blob/9ea4d3c8202ca500e3cc0bf9f7a2ffb9d4755d4f/dispatcher_plugin_nb2workflow/products.py#L241 which refers to the main code https://github.com/oda-hub/dispatcher-app/blob/e8f8082f68008510a7c9e865ff883c34852890a4/cdci_data_analysis/analysis/products.py#L406 completely separate from what's in oda_api. Not saying that we will also have a js visualisation library...

volodymyrss commented 1 month ago

need to replace this with the coming ogip functionality

when reading from file, there should be product-specific validation and transformation (i.e. loose reading and strict writing)