search

oda-hub / oda_api

API client to access some of the MMODA resources: INTEGRAL, POLAR, ANTARES, LIGO/Virgo, SDSS
Other
2 stars 2 forks source link

secret access API added based on renku secrets implementation #271

Open okolo opened 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 38.09524% with 13 lines in your changes missing coverage. Please review.

Project coverage is 19.14%. Comparing base (02e47e3) to head (4c13879).

Files with missing lines Patch % Lines
tests/test_secret.py 42.85% 8 Missing :warning:
oda_api/secret.py 28.57% 5 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (02e47e3) and HEAD (4c13879). Click for more details.

HEAD has 3 uploads less than BASE | Flag | BASE (02e47e3) | HEAD (4c13879) | |------|------|------| ||4|1|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #271 +/- ## =========================================== - Coverage 59.00% 19.14% -39.87% =========================================== Files 23 25 +2 Lines 4945 4963 +18 =========================================== - Hits 2918 950 -1968 - Misses 2027 4013 +1986 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

volodymyrss commented 3 months ago

Thanks! There is readthedocs in this repo, could you add a section there?

ferrigno commented 2 months ago

Note that this PR is already published in docs at https://odahub.io/docs/guide-development/ Please merge it !

dsavchenko commented 2 months ago

Live API tests issue is most likely on the production instance side.