search

oda-hub / oda_api

API client to access some of the MMODA resources: INTEGRAL, POLAR, ANTARES, LIGO/Virgo, SDSS
Other
2 stars 2 forks source link

Remove dispatcher plot dependencies and upgrade bokeh #279

Open ferrigno opened 3 months ago

ferrigno commented 3 months ago

As discussed some time ago, I removed the dependency we had from Dispatcher by moving the class into plot_tools. There is some code duplication from the two plot tools, but it looks reasonable.

@burnout87 please check if I was supposed to increase the version in setup.cfg and in case remove this change

I updated the requirements both n the requirements.txt file and in setup.py

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 22.80702% with 44 lines in your changes missing coverage. Please review.

Project coverage is 58.79%. Comparing base (02e47e3) to head (ba4ec4f).

Files Patch % Lines
oda_api/plot_tools.py 22.80% 44 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #279 +/- ## ========================================== - Coverage 59.00% 58.79% -0.22% ========================================== Files 23 23 Lines 4945 4997 +52 ========================================== + Hits 2918 2938 +20 - Misses 2027 2059 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dsavchenko commented 2 months ago

There is some code duplication from the two plot tools, but it looks reasonable.

That's ok, then we will be able to remove the duplication from the dispatcher code.