odan / slim4-skeleton

A Slim 4 Skeleton
https://odan.github.io/slim4-skeleton/
MIT License
439 stars 80 forks source link

Update LoggerFactory.php #58

Closed raduungurean closed 3 years ago

raduungurean commented 3 years ago

fixing testLogger error

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

odan commented 3 years ago

Hi @raduungurean Thanks for your contribution. What kind of error does this fix?

raduungurean commented 3 years ago

Hi! When $settings['test'] is not set I'm getting this error.

Fatal error: Uncaught Error: Typed property App\Factory\LoggerFactory::$testLogger must not be accessed before initialization in /var/www/html/src/Factory/LoggerFactory.php on line 49

odan commented 3 years ago

Thanks!