search

odan / slim4-skeleton

A Slim 4 Skeleton
https://odan.github.io/slim4-skeleton/
MIT License
439 stars 80 forks source link

Offset not working in UserFinderRepository.php #59

Closed ziauddin closed 3 years ago

ziauddin commented 3 years ago

$offset = min($params['offset'] ?? 0, 0); I think this line return always 0 If I set positive integer value in the $param['offset']. So I fixing it in my repository function and just pointed in here as a reminder its not working :-).

I really like this repository and its really helpful to understood slim and use it for my current api development project. Really appreciate. Ziauddin

odan commented 3 years ago

Good catch. It should be $offset = max($params['offset'] ?? 0, 0);. Would you like to create a PR?

ziauddin commented 3 years ago

I would love to and I wish to contribute more on this project.

odan commented 3 years ago

Fixed #60