Closed fanick1 closed 5 years ago
Asi jo, uz jsem nemel sily :). Jeste to porefaktoruju. Zavedl bych nejakou tridu "Event processor", ktera by se starala prave o tohleto. Jeste me napadlo, ze by tenhle polling pri prirazovani controllu slo nahradit nejakou "prirazovaci" GUI komponentou, ktera by proste mela focus a ty on keydown eventy by se ji zpropagovaly ( z Application nebo teda z toho Event processoru). To by ale znamenalo naimplementovat focus. F
On Tue, Sep 11, 2018, 10:53 AM Ondřej Daněk notifications@github.com wrote:
@odanek commented on this pull request.
In source/Menu.cpp https://github.com/odanek/duel6r/pull/84#discussion_r216592521:
SDL_Event event;
- while (SDL_PollEvent(&event)) {
- // Eat all remaining keyboard events;
- int result = 0;
- //TODO This logic duplicates event processing logic in Application. Should be refactored.
Nejde to teda odsud i z Application hodit do nejake funkce, ktera by se volala z obou mist?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/odanek/duel6r/pull/84#pullrequestreview-154106753, or mute the thread https://github.com/notifications/unsubscribe-auth/AD-05ZTK27qIDm04XaQx6uEDsPwzRC3Cks5uZ3n_gaJpZM4WiRX6 .
Ok, pockam jestli to jeste nejak uceses. Jinak jo, ty eventy, zejmena takove to cekani na stisk klavesy v Menu apod. jsou nedoreseny, je tam dost problemu.