Closed ibrahimyilmaz closed 4 years ago
Hey, @ibrahimyilmaz will give it a look and give a review.
Thanks for contributing.👍
It seems I can't run this pr, the app doesn't launch
You could remove the
//...
androidLogger(Level.DEBUG)
from the applications on create, since I don't think it's ever used
It was there when I forked. But anyway I will remove it :). Without this Logger it is running and that's why I wrote about that wiyh stackoverflow link :)
Yeah just went through it. Since its, a side effect brought about by the Kotlin update and it isn't being used anymore. It's safe to remove it. I can then look at whats up with the build.
I have checked the build.
Starting 0 tests on test(AVD) - 5.1.1
2845Tests on test(AVD) - 5.1.1 failed: Instrumentation run failed due to 'java.lang.NoSuchMethodError'
2846
2847com.android.builder.testing.ConnectedDevice > No tests found.[test(AVD) - 5.1.1] FAILED
2848No tests found. This usually means that your test classes are not in the form that your test runner expects (e.g. don't inherit from TestCase or lack @Test annotations).
2849
2850> Task :app:connectedDebugAndroidTest FAILED
I think it is related to test runner library. somehow it does not find @Test
s
Hmm looking into it
Finally saw it , under the androidTest
folder in the TheForceTestApplication
remove the androidLogger(Level.DEBUG)
as well.
That should solve the no tests part
@odaridavid crazy! Good catch man!
Merging #126 into develop will decrease coverage by
2.54%
. The diff coverage is34.32%
.
@@ Coverage Diff @@
## develop #126 +/- ##
===========================================
- Coverage 70.37% 67.83% -2.55%
===========================================
Files 42 43 +1
Lines 638 628 -10
Branches 106 110 +4
===========================================
- Hits 449 426 -23
- Misses 121 134 +13
Partials 68 68
Impacted Files | Coverage Δ | |
---|---|---|
...tlin/com/k0d4black/theforce/TheForceApplication.kt | 100.00% <ø> (ø) |
|
...ack/theforce/activities/FavoriteDetailsActivity.kt | 0.00% <0.00%> (ø) |
|
.../k0d4black/theforce/adapters/FavoriteViewHolder.kt | 0.00% <0.00%> (ø) |
|
...kotlin/com/k0d4black/theforce/adapters/Adapters.kt | 5.40% <5.40%> (ø) |
|
...k0d4black/theforce/activities/DashboardActivity.kt | 61.95% <66.66%> (+0.25%) |
:arrow_up: |
...ck/theforce/activities/CharacterDetailsActivity.kt | 66.66% <100.00%> (ø) |
|
.../com/k0d4black/theforce/adapters/FilmViewHolder.kt | 100.00% <100.00%> (ø) |
|
...k/theforce/adapters/SearchedCharacterViewHolder.kt | 100.00% <100.00%> (ø) |
|
...om/k0d4black/theforce/adapters/SpecieViewHolder.kt | 100.00% <100.00%> (ø) |
|
... and 4 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0ba926b...f7c56dc. Read the comment docs.
Hi there,
If you like, I would like to contribute your project by integrating Kiel RecyclerView Builders.
Any feedbacks about Kiel are greatly appreciated.
Also there is a known bug in Koin(maybe you may fix):
https://stackoverflow.com/questions/63393507/java-lang-nosuchmethoderror-no-virtual-method-elapsednowd-in-class-lkotlin-ti
Sincerely Ibra