Adds support to use OpenID Connect Auth

odavid / my-bloody-jenkins

Self Configured Jenkins Docker image based on Jenkins-LTS

MIT License

251 stars 71 forks source link

Adds support to use OpenID Connect Auth #162

Closed Reuuke closed 4 years ago

Reuuke commented 4 years ago

Following changes are:

Adds support to use OpenID Connect to authenticate using self-hosted or public OpenID connect providers.

odavid commented 4 years ago

Hi @Reuuke, Thank you for the contribution!

Can you please add tests for that configuration. See: https://github.com/odavid/my-bloody-jenkins/blob/master/tests/groovy/config-handlers/SecurityConfigTest.groovy#L20 as an example...

Cheers...

Reuuke commented 4 years ago

For every config, there is a need for automated test. See https://github.com/odavid/my-bloody-jenkins/blob/master/tests/groovy/config-handlers/SecurityConfigTest.groovy#L20 as an example

Done :)

odavid commented 4 years ago

@Reuuke - did you close this PR on purpose? Just curious...

Reuuke commented 4 years ago

@Reuuke - did you close this PR on purpose? Just curious...

Oops. Misclick

odavid commented 4 years ago

@Reuuke - Thank you! FYI - while guiding you, I missed the part where you need to actually call the test (: I fixed that here https://github.com/odavid/my-bloody-jenkins/commit/1c1b99ce17081229915e3b42ea5cd44a4dd65fa2#diff-02b70e45ed3c4c71cbc6d5c4b2d26c6dR300

Will let the CI run and when it passes, will release a version... Best...