search

odavid / my-bloody-jenkins

Self Configured Jenkins Docker image based on Jenkins-LTS
MIT License
251 stars 71 forks source link

WIP. Adds ability configure Job DSL Notifications #168

Closed Reuuke closed 4 years ago

Reuuke commented 4 years ago

Adds the ability to configure DSL Jobs Notifications (https://jenkinsci.github.io/job-dsl-plugin/#path/pipelineJob-notifications)

odavid commented 4 years ago

Hi @Reuuke,

I try to keep the image with "popular" plugins that are commonly used, support pipeline and maintained on a regular basis. Unfortunately, it seems that the Notifications plugin, does not match these criteria... Also the same notification can be done by using the dsl pipeline itself (using try/catch...)

I am sorry for that, but I don't think I will add that to the image.

I really thank you for all your work!

Reuuke commented 4 years ago

Hi @Reuuke,

I try to keep the image with "popular" plugins that are commonly used, support pipeline and maintained on a regular basis. Unfortunately, it seems that the Notifications plugin, does not match these criteria... Also the same notification can be done by using the dsl pipeline itself (using try/catch...)

I am sorry for that, but I don't think I will add that to the image.

I really thank you for all your work!

Hm, It does not require the installation of the new plugin, it is already included in the current image as part of "job-dsl-plugin" (I guess).

Also the same notification can be done by using the dsl pipeline itself (using try/catch...)

I will try to make a solution with this construction.

Reuuke commented 4 years ago

Oh, sorry. I did not notice that it turns out that we install it additionally via environment variable :( I really thought it was the default plugin :(