[Feature Request] Security: github-oauth authorisation strategy support

odavid / my-bloody-jenkins

Self Configured Jenkins Docker image based on Jenkins-LTS

MIT License

251 stars 71 forks source link

[Feature Request] Security: github-oauth authorisation strategy support #184

Closed Sudokamikaze closed 3 years ago

Sudokamikaze commented 3 years ago

Hi,

I'd like to open a FR for github-oauth/gitlab-oauth authorisation strategy, It could be implemented with the same as Google implemented, here you can find few snippets https://plugins.jenkins.io/github-oauth/

I can implement it if you don't mind, but let's discuss before any further actions

Thank you!

odavid commented 3 years ago

Hi, Sorry for the late response... Sure, I have no problem at all... Just pay attention to:

README
Tests
sorted plugins.txt

Sudokamikaze commented 3 years ago

Hi @odavid Sorry for late response as well :)

I've implemented it in https://github.com/odavid/my-bloody-jenkins/pull/189 Running tests right now, will post results in PR

Thank you :)

Sudokamikaze commented 3 years ago

Thanks for merging my patch!