transaction w/o class method decorator

[lytc]

Firstly, thank for your awesome lib @odavid !

In our current project we're on the way to use this lib to resolve some issues which we're facing with TypeORM core transaction. But we found that this lib just supported class method decorator. I implemented two helpers that can help to run transaction in the middle of the method/function body or wrap the a function that will run in transaction

import { Transactional } from 'typeorm-transactional-cls-hooked';

export class TransactionRunner {
  @Transactional()
  static run<Func extends (this: any, ...args: any[]) => ReturnType<Func>>(fn: Func) {
    return fn();
  }
}

export function wrapInTransaction<Func extends (this: any, ...args: any[]) => ReturnType<Func>>(
  fn: Func
): Func {
  function wrapped(this: unknown, ...newArgs: unknown[]): ReturnType<Func> {
    return TransactionRunner.run(() => fn.apply(this, newArgs));
  }

  return wrapped as Func;
}

Then we can use it like this:

function myService() {
  // do something here, e.g. call external service to get data
  ....
  TransactionRunner.run(() => {
    ....
  })
}

Or wrap a function:

function myService() {
 // do something
 .....
}
export default wrapInTransaction(myService);

But the problem is that I couldn't found a way to pass Propagation and Isolation option to these functions. Is there any suggestion or it's reasonable to create a new PR that will extract the logic from Transactional.ts?

[odavid]

Hi,

PR will be reasonable...

Cheers

[Glench]

I think this can be closed now that the PR was merged, although this should probably be documented in the README.