oddball / ipxact2systemverilog

Translates IPXACT XML to synthesizable VHDL or SystemVerilog
GNU General Public License v2.0
57 stars 19 forks source link

Register description is not mandatory #25

Closed vermaete closed 3 years ago

vermaete commented 3 years ago

Hi Andreas,

I had a register without description and the python code failed on it. The XML itself was valid. A description of a registers seems to be not needed in IP-XACT.

I've modified one of your test registers so it does not have a description. And modified the Python code if there is no description element, it will add an empty string as description. This makes it a bit easier to maintain the code. And I prefer having a 'Description:' line in the documentation so that it's clear it's better to add a description.

Thanks for reviewing.

oddball commented 3 years ago

LGTM