oddballteam / magnifier

1 stars 0 forks source link

71 week in review page #72

Closed hpjaj closed 5 years ago

hpjaj commented 5 years ago

Background

We are currently getting back a list of Statistics for a given time period (i.e. this week, last week, etc.), broken out into the 6 MVP categories (i.e. issues created, issues worked, etc.).

We need to be able to persist all of these statistics as a user's "week in review".

The required database work was completed in https://github.com/oddballio/magnifier/pull/69

Issue Resolved

Issue #71

Definition of Done

Preview

2018-12-12 15 54 31

kfrz commented 5 years ago

@hpjaj looks great to me, other than the single spec failure

Failure/Error: expect(statistics.count).to eq 2

  expected: 2
       got: 3

  (compared using ==)
./spec/services/week_in_reviews/filter_spec.rb:39:in `block (3 levels) in <main>'