All of these methods should be converted into find_or_create_by! methods, to avoid potential failures when a user manually adds in a stat into their Week in Review.
For example, if a user removes an Accomplishment from their "issues created", still has it in their "issues worked" section. And then later wants to add it back to their "issues created" section. There would be a collision with the existing "issues worked" `Accomplishment during the create process, due to validations on that model.
Definition of Done
[x] All of these methods are converted into find_or_create_by! methods
hpjaj
commented
5 years ago
Background
All of these methods should be converted into
find_or_create_by!methods, to avoid potential failures when a user manually adds in a stat into their Week in Review.For example, if a user removes an
Accomplishmentfrom their "issues created", still has it in their "issues worked" section. And then later wants to add it back to their "issues created" section. There would be a collision with the existing "issues worked" `Accomplishment during the create process, due to validations on that model.Definition of Done
find_or_create_by!methods