oddbird / accoutrement-scale

Size and scale helpers for typography and layout
MIT License
9 stars 1 forks source link

Function round #8

Closed mg901 closed 7 years ago

mg901 commented 7 years ago

Miriam, good time of day! Tell me please, is it possible to use the sass function round directly in $ sizes? If it is possible, then how can this be done? Please show the example of 'xs-leading'. Thanks in advance. `$ratios: ( 'major-third': 1.25, 'minor-sixth': 1.6, );

$sizes: ( 'root': 16px, 'xs-line': 1 ('minor-sixth': 1),

// XS 'xs-base': 16px, 'xs-leading': 'xs-base' ('minor-sixth': 1),

'xs-text': 'xs-base' ('major-third': 0, 'convert-units': 'rem'), 'xs-h1': 'xs-base' ('major-third': 5, 'convert-units': 'rem'), 'xs-h2': 'xs-base' ('major-third': 4, 'convert-units': 'rem'), 'xs-h3': 'xs-base' ('major-third': 3, 'convert-units': 'rem'), 'xs-h4': 'xs-base' ('major-third': 2, 'convert-units': 'rem'), 'xs-h5': 'xs-base' ('major-third': 1, 'convert-units': 'rem'), 'xs-h6': 'xs-base' ('major-third': 1, 'convert-units': 'rem'), ) `

mg901 commented 7 years ago

I apologize. I looked at the source code and understood that there is no such possibility.

mirisuzanne commented 7 years ago

Actually, I think this would be solvable, and a nice feature. You should be able to:

'xs-leading': 'xs-base' ('minor-sixth': 1, 'round': 'no-args'),

I just made up no-args, and maybe we could come up with something better. The only reason it doesn't work currently is that it assumes you always have at least one argument to pass along.

mirisuzanne commented 7 years ago

closed by 9710a0b