oddbird / css-anchor-positioning

Polyfill for CSS Anchor Positioning

https://anchor-polyfill.netlify.app/

BSD 3-Clause "New" or "Revised" License

225 stars 5 forks source link

Position anchor #196

Closed jamesnw closed 2 weeks ago

jamesnw commented 1 month ago

Description

Implements the position-anchor property.

Related Issue(s)

179

Steps to test/reproduce

View the demo in a browser that needs the polyfill, and apply the polyfill.

Show me

[x] Update Tests
[x] Confirm CSSTree parsing .class#id as .class #id is not an internal bug
[x] Support auto value (defer until later)

netlify[bot] commented 1 month ago

Deploy Preview for anchor-polyfill ready!

Name	Link
Latest commit	e205a2221d28f9a8b416596c9ceec310237ac8fe
Latest deploy log	https://app.netlify.com/sites/anchor-polyfill/deploys/6679d981125f3500087997ea
Deploy Preview	https://deploy-preview-196--anchor-polyfill.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for anchor-position-wpt canceled.

Name	Link
Latest commit	e205a2221d28f9a8b416596c9ceec310237ac8fe
Latest deploy log	https://app.netlify.com/sites/anchor-position-wpt/deploys/6679d9815239330008ee6ae8

jamesnw commented 4 weeks ago

@jgerigmeyer This is ready for re-review at your convenience.

I did opt to leave out support position-anchor: auto, which is "equivalent to omitting the anchor element in anchor()", as implicit anchors are still pending in the spec, it isn't tested yet in WPT, and it isn't implemented yet in Chrome.

jamesnw commented 4 weeks ago

This does introduce a new regression in anchor-position-multicol-colspan-001.html, .target 3. This is related to #192.

This change passes 12 new subtests, mostly in areas where position-anchor is not the primary concept under test.

jgerigmeyer commented 2 weeks ago

@jamesnw I'm happy for you to merge this if you don't have more changes!