search

oddbird / oddcontrast

https://www.oddcontrast.com/
BSD 3-Clause "New" or "Revised" License
28 stars 1 forks source link

Add color issues section #146

Closed jamesnw closed 9 months ago

jamesnw commented 10 months ago

Description

Adds a section with space for more info on known color issues. Currently, only the Gamut mapping issue is documented- the Alpha caveats should be added with the related PRs.

Fixes #143

Steps to test/reproduce

  1. Open the page on a wide screen, see that the section defaults to open.
  2. Open the page on a narrow screen, see that the section defaults to closed.
  3. Open/close is not responsive, so changing the viewport won't change the state
  4. When the contrast doesn't meet AA Normal, it uses the same low contrast colors as the ratios.

Show me

image image
netlify[bot] commented 10 months ago

Deploy Preview for oddcontrast ready!

Name Link
Latest commit fee5ca9495bcc3643b9fc1de0defd642b4efd2d3
Latest deploy log https://app.netlify.com/sites/oddcontrast/deploys/659d64b8a8e9f000089ca755
Deploy Preview https://deploy-preview-146--oddcontrast.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jamesnw commented 10 months ago

This will need some design help from @stacyk or @dvdherron - there was some conflicts with the other definition list in use. I added the styles to the component, but assume they should be located elsewhere.

jamesnw commented 10 months ago

Note to the designers- I added a second issue in #145, which adds some additional complexity, so it may be worth styling with that content in mind.

dvdherron commented 9 months ago

@stacyk This is ready for style review.

stacyk commented 9 months ago

@jgerigmeyer I am assigning this to you because I see you left comments but haven't approved this PR yet.

stacyk commented 9 months ago

We shouldn't block the pr because of the transition, but i think there was a ridiculous duration and delay on that transition for testing that would need to be adjusted.

dvdherron commented 9 months ago

@stacyk I think my latest changes address everything except for the possible Safari transition bug. If you want to give this a last look I think this is soon ready to merge.