oddbird / oddcontrast

https://www.oddcontrast.com/
BSD 3-Clause "New" or "Revised" License
28 stars 1 forks source link

Warn about browser bugs in (ok)lch rendering #95

Closed mirisuzanne closed 9 months ago

mirisuzanne commented 1 year ago

Requested on social media:

Browser bugs to track:

mirisuzanne commented 1 year ago

I think this might be important, and we may even want to set display-p3 as the default. The current implementations of (ok)lab/lch colors are so bad, they're almost unusable. (Why did browsers ship it like this?)

SondraE commented 1 year ago

Draft Proposal

https://www.figma.com/file/JtQTGIpwoaOcqcWfsoeOk1/Browser-bugs-%26-other-warnings?type=design&node-id=0%3A1&mode=design&t=RuE2m0Xo75cF0fGM-1

jamesnw commented 1 year ago

(ok)lab bug report-

https://bugs.chromium.org/p/chromium/issues/detail?id=1439722

I didn't find ones for Webkit or Firefox.

Conversation regarding this from the CSS WG- https://github.com/w3c/csswg-drafts/issues/8794

SondraE commented 11 months ago

@mirisuzanne @stacyk Here are the warning-related Figma file links. Note: I don't know why Figma is suddenly displaying green lines around various bits of the mockups, and I haven't found the way to turn that view off yet.

Incorrect implementation + Expanded Color Issue Info https://www.figma.com/file/JtQTGIpwoaOcqcWfsoeOk1/Browser-bugs-%26-other-warnings?type=design&node-id=12%3A138&mode=design&t=4CwzTDrU2fakSiQ4-1

mirisuzanne commented 10 months ago

Left some comments on the designs. It seems like we should maybe break this out into smaller stories for the specific issues and warnings.

jamesnw commented 10 months ago

Scope

I removed the out of gamut check, to prevent lots of jumping around as colors are adjusted, and I don't think the usefulness is particularly tied to the user's current color.

stacyk commented 9 months ago

I removed myself but I didn't assign anyone else (yet, wasn't sure what is left on 146, or if that matters here).