oddbird / popover-polyfill

Polyfills the HTML popover attribute and showPopover/hidePopover/togglePopover methods onto HTMLElement, as well as the popovertarget and popovertargetaction attributes on <button> elements.
BSD 3-Clause "New" or "Revised" License
259 stars 14 forks source link

"Click to toggle shadowed Popover" crashes in Firefox 118 #139

Closed jgerigmeyer closed 11 months ago

jgerigmeyer commented 1 year ago

It's not new in this PR, but I notice that the "Click to toggle shadowed Popover" button crashes the tab for me when clicked in FF 118

That's interesting. Is that on stock Firefox, or have you enabled popovers or some shadowdom features? I can't reproduce locally, but it'd be interesting to investigate. Do you have a crash report?

This is stock Firefox 118.0.2 with popovers disabled. It works fine for me in Safari 16.6 (using the polyfill). If I test in Chrome (popovers enabled) or Firefox (popovers enabled), the button just doesn't do anything. Crash report: https://crash-stats.mozilla.org/report/index/7ac206de-9229-402a-9e6f-31ee80231019

Originally posted by @jgerigmeyer in https://github.com/oddbird/popover-polyfill/issues/137#issuecomment-1771131154