search

oddbird / popover-polyfill

Polyfills the HTML popover attribute and showPopover/hidePopover/togglePopover methods onto HTMLElement, as well as the popovertarget and popovertargetaction attributes on <button> elements.
BSD 3-Clause "New" or "Revised" License
249 stars 14 forks source link

upgrade to typescript@5.2.2 #146

Closed keithamus closed 10 months ago

keithamus commented 10 months ago

Description

TypeScript recently added definitions for popover which conflict with the ones in this repository.

This updates the TS definitions to be compatible with those from TypeScript, so that users of older versions of TypeScript will still get the types, and for users of newer versions the code won't run into type conflicts.

Steps to test/reproduce

Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).

$ git checkout origin/main -f
$ npm i typescript@latest -D
$ npm run build # observe the errrors!

Show me

Provide screenshots/animated gifs/videos if necessary. N/A

netlify[bot] commented 10 months ago

Deploy Preview for popover-polyfill ready!

Name Link
Latest commit 281c230fb620071c7335fc0c2e553fbf18afb05e
Latest deploy log https://app.netlify.com/sites/popover-polyfill/deploys/65524bfe9bf2470008bc5a1c
Deploy Preview https://deploy-preview-146--popover-polyfill.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.