Closed keithamus closed 10 months ago
Name | Link |
---|---|
Latest commit | 8b70eafe75df29939a62d2c34ba331a1eb7a00e3 |
Latest deploy log | https://app.netlify.com/sites/popover-polyfill/deploys/65a668ba02a45400085e6592 |
Deploy Preview | https://deploy-preview-170--popover-polyfill.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Do you think we want a similar change here?
I tried to use synthetic events to close an open popover and it seems as though they get ignored, so my guess for now is that we do not. If we can reproduce a discrepancy then I'd suggest we might want to, but until then I'd like to not remove that line.
Released in v0.3.8.
Description
In https://github.com/philc/vimium/issues/4369 it has been noted that popovers don't work with the Firefox "Vimium" extension. This is, I suspect, because Vimium is synthesising click events and the popover polyfill checks if the event
isTrusted
(coming from the browser and not from scripts).Trying to reproduce this in https://codepen.io/keithamus/pen/MWxJxOR we can see that the polyfill - when used - renders the button inert due to this guard, however native popover does not have the same guard and so in browsers with native popover (Chrome, WebKit) it is not inert.
Consequently we should remove this guard to ensure behaviour aligns with native.
Related Issue(s)
https://github.com/philc/vimium/issues/4369
Steps to test/reproduce
dom.element.popover.enabled
is set tofalse
Show me
Provide screenshots/animated gifs/videos if necessary.