oddbird / popover-polyfill

Polyfills the HTML popover attribute and showPopover/hidePopover/togglePopover methods onto HTMLElement, as well as the popovertarget and popovertargetaction attributes on <button> elements.

BSD 3-Clause "New" or "Revised" License

247 stars 14 forks source link

Ensure click events correctly cross out of ShadowDOM #177

Closed Prestaul closed 7 months ago

Prestaul commented 7 months ago

Related Issue(s)

176

Steps to test/reproduce

Populate the shadow dom of any element inside of a button that is a popovertrigger
When a click originates from within the shadow dom, the popover is not triggers

netlify[bot] commented 7 months ago

Deploy Preview for popover-polyfill ready!

Name	Link
Latest commit	3457ec7c9d14a1180d0358395d8175fcb25ba2d7
Latest deploy log	https://app.netlify.com/sites/popover-polyfill/deploys/65c3fafe3f401600082415ce
Deploy Preview	https://deploy-preview-177--popover-polyfill.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Prestaul commented 7 months ago

@jgerigmeyer, it looks like the build hasn't reported after almost an hour. Did I break it by force pushing? Let me know if there is anything I need to do to correct whatever I've broken.

jgerigmeyer commented 7 months ago