search

oddbird / popover-polyfill

Polyfills the HTML popover attribute and showPopover/hidePopover/togglePopover methods onto HTMLElement, as well as the popovertarget and popovertargetaction attributes on <button> elements.
BSD 3-Clause "New" or "Revised" License
247 stars 14 forks source link

Do not close parent popover when shadowed nested popover is opened #190

Closed jgerigmeyer closed 5 months ago

jgerigmeyer commented 5 months ago

See new "Toggle menu with shadowed nested popover" button with nested "Toggle inner shadowed popover" button.

Before: clicking "Toggle inner shadowed popover" closes both popovers After: clicking "Toggle inner shadowed popover" opens inner nested popover

Fixes #183

netlify[bot] commented 5 months ago

Deploy Preview for popover-polyfill ready!

Name Link
Latest commit 07bd18d3e30a5ad78f9c3437ebc9b04be9abbb8a
Latest deploy log https://app.netlify.com/sites/popover-polyfill/deploys/65fdf77c9c36c30008955d49
Deploy Preview https://deploy-preview-190--popover-polyfill.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jgerigmeyer commented 5 months ago

@keithamus Does this seem like an okay solution to #183?