Polyfill doesn't seem to work with dialog element

oddbird / popover-polyfill

Polyfills the HTML popover attribute and showPopover/hidePopover/togglePopover methods onto HTMLElement, as well as the popovertarget and popovertargetaction attributes on <button> elements.

BSD 3-Clause "New" or "Revised" License

247 stars 14 forks source link

Polyfill doesn't seem to work with dialog element #198

Closed samGbos closed 4 months ago

samGbos commented 4 months ago

I was trying to set a <dialog> to be a popover as discussed here: https://hidde.blog/popover-semantics/

However, this doesn't seem to work in Firefox; the popover does seem to work with a <div> element though: https://codepen.io/codepenguy131/pen/jORdKGo

jgerigmeyer commented 4 months ago

@samGbos Thanks for reporting! It looks to me like that's a bug -- I've submitted a fix in #199: https://deploy-preview-199--popover-polyfill.netlify.app/

samGbos commented 4 months ago

Amazing, thanks! Such a quick response!

jgerigmeyer commented 4 months ago

@samGbos Released in v0.4.2