search

oddbird / popover-polyfill

Polyfills the HTML popover attribute and showPopover/hidePopover/togglePopover methods onto HTMLElement, as well as the popovertarget and popovertargetaction attributes on <button> elements.
https://popover.oddbird.net
BSD 3-Clause "New" or "Revised" License
269 stars 14 forks source link

Return null for disconnected elements #90

Closed keithamus closed 1 year ago

keithamus commented 1 year ago

Was reading through some of this code and noticed this discrepancy. We should return null for disconnected elements.

Steps to test/reproduce

Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).

Show me

Provide screenshots/animated gifs/videos if necessary.

netlify[bot] commented 1 year ago

Deploy Preview for popover-polyfill ready!

Name Link
Latest commit 87d4225b567f7d4f4e7444f9262b7aba39812243
Latest deploy log https://app.netlify.com/sites/popover-polyfill/deploys/64259af3463fb7000854cb1f
Deploy Preview https://deploy-preview-90--popover-polyfill.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.